-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next): resolve absolute path to @babel/runtime #18921
Conversation
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 13.7s | 13.7s | |
nodeModulesSize | 84.9 MB | 84.9 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.583 | 2.595 | |
/ avg req/sec | 967.99 | 963.51 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.637 | 1.584 | -0.05 |
/error-in-render avg req/sec | 1526.75 | 1578.48 | +51.73 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | 11.3 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | 7.4 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | 1.55 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
index.html gzip | 1 kB | 999 B | -2 B |
link.html gzip | 1.01 kB | 1.01 kB | -2 B |
withRouter.html gzip | 995 B | 993 B | -2 B |
Overall change | 3.01 kB | 3 kB | -6 B |
Diffs
Diff for _buildManifest.js
@@ -2,12 +2,12 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-760f653e71e48010adf7.js"
],
"/hooks": [
- "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+ "static\u002Fchunks\u002Fpages\u002Fhooks-880757f1d73d6b241fc3.js"
],
- "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fcaf825022c62b02057c.js"],
+ "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3125d338b922d5ab1776.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
],
Diff for _buildManifest.module.js
@@ -4,7 +4,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Findex-dc79232991b9d18c3260.module.js"
],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-714d7bb4196263406c6e.module.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-b59ce1d1aef722bdb502.module.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-56fa58a6f0993d7d36d7.module.js"
Diff for index.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for link.html
@@ -90,7 +90,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -126,7 +126,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -138,7 +138,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -150,7 +150,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/link-fcaf825022c62b02057c.js"
+ src="/_next/static/chunks/pages/link-3125d338b922d5ab1776.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for withRouter.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 15.6s | 15.6s | |
nodeModulesSize | 84.9 MB | 84.9 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | N/A | N/A |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | N/A | N/A |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
677f882d2ed8..5283.js gzip | N/A | 11.3 kB | N/A |
main-ea56374..0cae.js gzip | N/A | 7.4 kB | N/A |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | N/A | N/A |
_error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
hooks-d4591d..e7c2.js gzip | 887 B | N/A | N/A |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | N/A | N/A |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
_app-3b0cf13..85f8.js gzip | N/A | 1.28 kB | N/A |
_error-6f635..c393.js gzip | N/A | 3.44 kB | N/A |
hooks-d4ffc3..9e0f.js gzip | N/A | 887 B | N/A |
link-0abe79e..7616.js gzip | N/A | 1.55 kB | N/A |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | N/A | N/A |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
_error-f2fcc..dule.js gzip | N/A | 2.29 kB | N/A |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Serverless bundles
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_error.js | 915 kB | 915 kB | ✓ |
404.html | 4.73 kB | 4.73 kB | ✓ |
hooks.html | 3.92 kB | 3.92 kB | ✓ |
index.js | 915 kB | 915 kB | ✓ |
link.js | 964 kB | 964 kB | ✓ |
routerDirect.js | 957 kB | 957 kB | ✓ |
withRouter.js | 957 kB | 957 kB | ✓ |
Overall change | 4.72 MB | 4.72 MB | ✓ |
Failing test suitesCommit: 32637b4 test/unit/next-babel.test.js
Expand output● next/babel › jsx-pragma › should transform JSX to use a local identifier in CommonJS mode
|
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 13.8s | 13.4s | -396ms |
nodeModulesSize | 84.9 MB | 84.9 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.52 | 2.43 | -0.09 |
/ avg req/sec | 991.97 | 1029.02 | +37.05 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.358 | 1.3 | -0.06 |
/error-in-render avg req/sec | 1840.38 | 1923.22 | +82.84 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | 11.3 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | 7.4 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | 1.55 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
index.html gzip | 1 kB | 999 B | -2 B |
link.html gzip | 1.01 kB | 1.01 kB | -2 B |
withRouter.html gzip | 995 B | 993 B | -2 B |
Overall change | 3.01 kB | 3 kB | -6 B |
Diffs
Diff for _buildManifest.js
@@ -2,12 +2,12 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-760f653e71e48010adf7.js"
],
"/hooks": [
- "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+ "static\u002Fchunks\u002Fpages\u002Fhooks-880757f1d73d6b241fc3.js"
],
- "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fcaf825022c62b02057c.js"],
+ "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3125d338b922d5ab1776.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
],
Diff for _buildManifest.module.js
@@ -4,7 +4,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Findex-dc79232991b9d18c3260.module.js"
],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-714d7bb4196263406c6e.module.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-b59ce1d1aef722bdb502.module.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-56fa58a6f0993d7d36d7.module.js"
Diff for index.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for link.html
@@ -90,7 +90,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -126,7 +126,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -138,7 +138,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -150,7 +150,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/link-fcaf825022c62b02057c.js"
+ src="/_next/static/chunks/pages/link-3125d338b922d5ab1776.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for withRouter.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 15.4s | 15.2s | -251ms |
nodeModulesSize | 84.9 MB | 84.9 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | N/A | N/A |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | N/A | N/A |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
677f882d2ed8..5283.js gzip | N/A | 11.3 kB | N/A |
main-ea56374..0cae.js gzip | N/A | 7.4 kB | N/A |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | N/A | N/A |
_error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
hooks-d4591d..e7c2.js gzip | 887 B | N/A | N/A |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | N/A | N/A |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
_app-3b0cf13..85f8.js gzip | N/A | 1.28 kB | N/A |
_error-6f635..c393.js gzip | N/A | 3.44 kB | N/A |
hooks-d4ffc3..9e0f.js gzip | N/A | 887 B | N/A |
link-0abe79e..7616.js gzip | N/A | 1.55 kB | N/A |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | N/A | N/A |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
_error-f2fcc..dule.js gzip | N/A | 2.29 kB | N/A |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Serverless bundles
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_error.js | 915 kB | 915 kB | ✓ |
404.html | 4.73 kB | 4.73 kB | ✓ |
hooks.html | 3.92 kB | 3.92 kB | ✓ |
index.js | 915 kB | 915 kB | ✓ |
link.js | 964 kB | 964 kB | ✓ |
routerDirect.js | 957 kB | 957 kB | ✓ |
withRouter.js | 957 kB | 957 kB | ✓ |
Overall change | 4.72 MB | 4.72 MB | ✓ |
Failing test suitesCommit: 53ebc8b test/unit/next-babel.test.js
Expand output● next/babel › jsx-pragma › should transform JSX to use a local identifier in CommonJS mode
|
Stats from current PRDefault Server Mode (Increase detected
|
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 11.6s | 11.7s | |
nodeModulesSize | 84.9 MB | 84.9 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.196 | 2.165 | -0.03 |
/ avg req/sec | 1138.56 | 1154.9 | +16.34 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.223 | 1.176 | -0.05 |
/error-in-render avg req/sec | 2044.73 | 2125.45 | +80.72 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | 11.3 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | 7.4 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | 1.55 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
index.html gzip | 1 kB | 999 B | -2 B |
link.html gzip | 1.01 kB | 1.01 kB | -2 B |
withRouter.html gzip | 995 B | 993 B | -2 B |
Overall change | 3.01 kB | 3 kB | -6 B |
Diffs
Diff for _buildManifest.js
@@ -2,12 +2,12 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-760f653e71e48010adf7.js"
],
"/hooks": [
- "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+ "static\u002Fchunks\u002Fpages\u002Fhooks-880757f1d73d6b241fc3.js"
],
- "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fcaf825022c62b02057c.js"],
+ "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3125d338b922d5ab1776.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
],
Diff for _buildManifest.module.js
@@ -4,7 +4,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Findex-dc79232991b9d18c3260.module.js"
],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-714d7bb4196263406c6e.module.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-b59ce1d1aef722bdb502.module.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-56fa58a6f0993d7d36d7.module.js"
Diff for index.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for link.html
@@ -90,7 +90,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -126,7 +126,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -138,7 +138,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -150,7 +150,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/link-fcaf825022c62b02057c.js"
+ src="/_next/static/chunks/pages/link-3125d338b922d5ab1776.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for withRouter.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 13.1s | 13.4s | |
nodeModulesSize | 84.9 MB | 84.9 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | N/A | N/A |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | N/A | N/A |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
677f882d2ed8..5283.js gzip | N/A | 11.3 kB | N/A |
main-ea56374..0cae.js gzip | N/A | 7.4 kB | N/A |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | N/A | N/A |
_error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
hooks-d4591d..e7c2.js gzip | 887 B | N/A | N/A |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | N/A | N/A |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
_app-3b0cf13..85f8.js gzip | N/A | 1.28 kB | N/A |
_error-6f635..c393.js gzip | N/A | 3.44 kB | N/A |
hooks-d4ffc3..9e0f.js gzip | N/A | 887 B | N/A |
link-0abe79e..7616.js gzip | N/A | 1.55 kB | N/A |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | N/A | N/A |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
_error-f2fcc..dule.js gzip | N/A | 2.29 kB | N/A |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Serverless bundles
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_error.js | 915 kB | 915 kB | ✓ |
404.html | 4.73 kB | 4.73 kB | ✓ |
hooks.html | 3.92 kB | 3.92 kB | ✓ |
index.js | 915 kB | 915 kB | ✓ |
link.js | 964 kB | 964 kB | ✓ |
routerDirect.js | 957 kB | 957 kB | ✓ |
withRouter.js | 957 kB | 957 kB | ✓ |
Overall change | 4.72 MB | 4.72 MB | ✓ |
Failing test suitesCommit: 8cda33a test/unit/next-babel.test.js
Expand output● next/babel › jsx-pragma › should transform JSX to use a local identifier in CommonJS mode
|
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 11.3s | 11.1s | -259ms |
nodeModulesSize | 84.9 MB | 84.9 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.155 | 2.154 | 0 |
/ avg req/sec | 1160.2 | 1160.84 | +0.64 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.195 | 1.201 | |
/error-in-render avg req/sec | 2092.36 | 2082.24 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | 11.3 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | 7.4 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | 1.55 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
index.html gzip | 1 kB | 999 B | -2 B |
link.html gzip | 1.01 kB | 1.01 kB | -2 B |
withRouter.html gzip | 995 B | 993 B | -2 B |
Overall change | 3.01 kB | 3 kB | -6 B |
Diffs
Diff for _buildManifest.js
@@ -2,12 +2,12 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-760f653e71e48010adf7.js"
],
"/hooks": [
- "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+ "static\u002Fchunks\u002Fpages\u002Fhooks-880757f1d73d6b241fc3.js"
],
- "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fcaf825022c62b02057c.js"],
+ "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3125d338b922d5ab1776.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
],
Diff for _buildManifest.module.js
@@ -4,7 +4,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Findex-dc79232991b9d18c3260.module.js"
],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-714d7bb4196263406c6e.module.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-b59ce1d1aef722bdb502.module.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-56fa58a6f0993d7d36d7.module.js"
Diff for index.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for link.html
@@ -90,7 +90,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -126,7 +126,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -138,7 +138,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -150,7 +150,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/link-fcaf825022c62b02057c.js"
+ src="/_next/static/chunks/pages/link-3125d338b922d5ab1776.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for withRouter.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-33a267df08fa8c5852a0.js"
+ src="/_next/static/chunks/main-e2ee97cbd323a481a27d.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 12.6s | 12.9s | |
nodeModulesSize | 84.9 MB | 84.9 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | N/A | N/A |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-d942eb5..343f.js gzip | 7.4 kB | N/A | N/A |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
677f882d2ed8..5283.js gzip | N/A | 11.3 kB | N/A |
main-ea56374..0cae.js gzip | N/A | 7.4 kB | N/A |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-34e64ff..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | N/A | N/A |
_error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
hooks-d4591d..e7c2.js gzip | 887 B | N/A | N/A |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | N/A | N/A |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
_app-3b0cf13..85f8.js gzip | N/A | 1.28 kB | N/A |
_error-6f635..c393.js gzip | N/A | 3.44 kB | N/A |
hooks-d4ffc3..9e0f.js gzip | N/A | 887 B | N/A |
link-0abe79e..7616.js gzip | N/A | 1.55 kB | N/A |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | N/A | N/A |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
_error-f2fcc..dule.js gzip | N/A | 2.29 kB | N/A |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Serverless bundles
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_error.js | 915 kB | 915 kB | ✓ |
404.html | 4.73 kB | 4.73 kB | ✓ |
hooks.html | 3.92 kB | 3.92 kB | ✓ |
index.js | 915 kB | 915 kB | ✓ |
link.js | 964 kB | 964 kB | ✓ |
routerDirect.js | 957 kB | 957 kB | ✓ |
withRouter.js | 957 kB | 957 kB | ✓ |
Overall change | 4.72 MB | 4.72 MB | ✓ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach may in theory be breaking since the require.resolve
being called here is effectively the one in the Babel preset build which might be different to the runtime require resolve.
Are you sure Webpack is leaving this unmodified? Would it work to replace this with eval('require').resolve
perhaps to ensure it is the runtime require?
Otherwise there does still seem to be some risk here that because it's a different resolve it might resolve a different runtime or not find the runtime.
I haven't fully understood the paths at play here, so if I'm wrong and missing something please let me know.
Also I was under the impression Babel runtime outputs a native |
The end result is the same, the path is just resolved up front instead of having
As far as I can tell this doesn't go through webpack
Correct, unless you specify |
The thing is aren't we doing the resolutions at different times in the workflow? Currently it is happening at the time the module is built / run / processed (to be honest I'm not quite sure when that is), while this would change the resolution time to being when the module is transformed.
I'm pretty sure ncc would be processing this
This is my concern - resolution from the transform and resolution from the runtime are very different environments. The Babel runtime is a direct dependency of Next.js, so runtime resolution should resolve that dependency but in theory it could be overridden in the runtime environment. On the other hand transform time resolution might even be inlining the runtime through ncc right now. Just being cautious to verify these cases - someone with more knowledge of these environments may be able to confirm more easily than myself. |
Only slighly, it's done when the babel preset is loaded instead of when the babel plugin needs to inject the import, but the end result is the same.
It doesn't as this doesn't go through ncc |
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 12.8s | 12.6s | -200ms |
nodeModulesSize | 85 MB | 85 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.269 | 2.395 | |
/ avg req/sec | 1101.8 | 1043.7 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.272 | 1.248 | -0.02 |
/error-in-render avg req/sec | 1965.3 | 2003.66 | +38.36 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | 11.3 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-6a509b2..b31a.js gzip | 7.4 kB | 7.4 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-0547acd..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | 1.55 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
index.html gzip | 1 kB | 1 kB | -3 B |
link.html gzip | 1.01 kB | 1.01 kB | -2 B |
withRouter.html gzip | 996 B | 995 B | -1 B |
Overall change | 3.01 kB | 3 kB | -6 B |
Diffs
Diff for _buildManifest.js
@@ -2,12 +2,12 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-760f653e71e48010adf7.js"
],
"/hooks": [
- "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+ "static\u002Fchunks\u002Fpages\u002Fhooks-880757f1d73d6b241fc3.js"
],
- "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fcaf825022c62b02057c.js"],
+ "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3125d338b922d5ab1776.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
],
Diff for _buildManifest.module.js
@@ -4,7 +4,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Findex-dc79232991b9d18c3260.module.js"
],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-714d7bb4196263406c6e.module.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-b59ce1d1aef722bdb502.module.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-56fa58a6f0993d7d36d7.module.js"
Diff for index.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-40f3a40e310cc5292a89.js"
+ src="/_next/static/chunks/main-2fd5c9125e922c10e577.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for link.html
@@ -90,7 +90,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-40f3a40e310cc5292a89.js"
+ src="/_next/static/chunks/main-2fd5c9125e922c10e577.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -126,7 +126,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -138,7 +138,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -150,7 +150,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/link-fcaf825022c62b02057c.js"
+ src="/_next/static/chunks/pages/link-3125d338b922d5ab1776.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for withRouter.html
@@ -85,7 +85,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-40f3a40e310cc5292a89.js"
+ src="/_next/static/chunks/main-2fd5c9125e922c10e577.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -121,7 +121,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6434721f788a4bf67b23.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -133,7 +133,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 14.4s | 13.3s | -1.1s |
nodeModulesSize | 85 MB | 85 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..7d3b.js gzip | 11.3 kB | N/A | N/A |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-6a509b2..b31a.js gzip | 7.4 kB | N/A | N/A |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
677f882d2ed8..5283.js gzip | N/A | 11.3 kB | N/A |
main-6ae41db..e5f1.js gzip | N/A | 7.4 kB | N/A |
Overall change | 58.4 kB | 58.4 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.04 kB | 7.04 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-0547acd..dule.js gzip | 6.39 kB | 6.39 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.1 kB | 53.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | N/A | N/A |
_error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
hooks-d4591d..e7c2.js gzip | 887 B | N/A | N/A |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | N/A | N/A |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
_app-3b0cf13..85f8.js gzip | N/A | 1.28 kB | N/A |
_error-6f635..c393.js gzip | N/A | 3.44 kB | N/A |
hooks-d4ffc3..9e0f.js gzip | N/A | 887 B | N/A |
link-0abe79e..7616.js gzip | N/A | 1.55 kB | N/A |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | N/A | N/A |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
_error-f2fcc..dule.js gzip | N/A | 2.29 kB | N/A |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Serverless bundles
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_error.js | 915 kB | 915 kB | ✓ |
404.html | 4.73 kB | 4.73 kB | ✓ |
hooks.html | 3.92 kB | 3.92 kB | ✓ |
index.js | 915 kB | 915 kB | ✓ |
link.js | 964 kB | 964 kB | ✓ |
routerDirect.js | 957 kB | 957 kB | ✓ |
withRouter.js | 957 kB | 957 kB | ✓ |
Overall change | 4.72 MB | 4.72 MB | ✓ |
Ok, if you are confident the environment isn't affected by other information then that sounds good to me, just had to check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 14.4s | 14.2s | -141ms |
nodeModulesSize | 84.8 MB | 84.8 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.716 | 2.751 | |
/ avg req/sec | 920.61 | 908.61 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.598 | 1.642 | |
/error-in-render avg req/sec | 1564.91 | 1522.73 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..3888.js gzip | 11.3 kB | 11.3 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-673683e..14c7.js gzip | 7.48 kB | 7.48 kB | ✓ |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
Overall change | 58.5 kB | 58.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.05 kB | 7.05 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-0c7333c..dule.js gzip | 6.47 kB | 6.47 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | 1.28 kB | ✓ |
_error-fca3d..2eb1.js gzip | 3.44 kB | 3.44 kB | ✓ |
hooks-d4591d..e7c2.js gzip | 887 B | 887 B | ✓ |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | 1.55 kB | ✓ |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | 2.29 kB | ✓ |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
index.html gzip | 969 B | 970 B | |
link.html gzip | 977 B | 977 B | ✓ |
withRouter.html gzip | 963 B | 963 B | ✓ |
Overall change | 2.91 kB | 2.91 kB |
Diffs
Diff for _buildManifest.js
@@ -2,12 +2,12 @@ self.__BUILD_MANIFEST = {
__rewrites: [],
"/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-9b57cae5694a39479222.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-760f653e71e48010adf7.js"
],
"/hooks": [
- "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"
+ "static\u002Fchunks\u002Fpages\u002Fhooks-880757f1d73d6b241fc3.js"
],
- "/link": ["static\u002Fchunks\u002Fpages\u002Flink-fcaf825022c62b02057c.js"],
+ "/link": ["static\u002Fchunks\u002Fpages\u002Flink-3125d338b922d5ab1776.js"],
"/routerDirect": [
"static\u002Fchunks\u002Fpages\u002FrouterDirect-2e9bfd441bd88cd3382e.js"
],
Diff for _buildManifest.module.js
@@ -4,7 +4,7 @@ self.__BUILD_MANIFEST = {
"static\u002Fchunks\u002Fpages\u002Findex-dc79232991b9d18c3260.module.js"
],
"/_error": [
- "static\u002Fchunks\u002Fpages\u002F_error-714d7bb4196263406c6e.module.js"
+ "static\u002Fchunks\u002Fpages\u002F_error-b59ce1d1aef722bdb502.module.js"
],
"/hooks": [
"static\u002Fchunks\u002Fpages\u002Fhooks-56fa58a6f0993d7d36d7.module.js"
Diff for index.html
@@ -82,7 +82,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-c12e76ab7fd8fce0bb80.js"
+ src="/_next/static/chunks/main-4350573f106c88c1a7e0.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -118,7 +118,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.84827680b822d5d16780.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c3dbd33b4fb43ac7e320.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -130,7 +130,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for link.html
@@ -87,7 +87,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-c12e76ab7fd8fce0bb80.js"
+ src="/_next/static/chunks/main-4350573f106c88c1a7e0.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -123,7 +123,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.84827680b822d5d16780.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c3dbd33b4fb43ac7e320.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -135,7 +135,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -147,7 +147,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/link-fcaf825022c62b02057c.js"
+ src="/_next/static/chunks/pages/link-3125d338b922d5ab1776.js"
async=""
crossorigin="anonymous"
nomodule=""
Diff for withRouter.html
@@ -82,7 +82,7 @@
src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
></script>
<script
- src="/_next/static/chunks/main-c12e76ab7fd8fce0bb80.js"
+ src="/_next/static/chunks/main-4350573f106c88c1a7e0.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -118,7 +118,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.84827680b822d5d16780.js"
+ src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c3dbd33b4fb43ac7e320.js"
async=""
crossorigin="anonymous"
nomodule=""
@@ -130,7 +130,7 @@
type="module"
></script>
<script
- src="/_next/static/chunks/pages/_app-265ddf2d03dbe48fa6cb.js"
+ src="/_next/static/chunks/pages/_app-a24430c6b07ae4b780ba.js"
async=""
crossorigin="anonymous"
nomodule=""
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
buildDuration | 16.7s | 17.2s | |
nodeModulesSize | 84.8 MB | 84.8 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..3888.js gzip | 11.3 kB | N/A | N/A |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-673683e..14c7.js gzip | 7.48 kB | N/A | N/A |
webpack-e067..f178.js gzip | 751 B | 751 B | ✓ |
677f882d2ed8..01e7.js gzip | N/A | 11.3 kB | N/A |
main-3e470be..d458.js gzip | N/A | 7.48 kB | N/A |
Overall change | 58.5 kB | 58.5 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
677f882d2ed8..dule.js gzip | 7.05 kB | 7.05 kB | ✓ |
framework.HA..dule.js gzip | 39 kB | 39 kB | ✓ |
main-0c7333c..dule.js gzip | 6.47 kB | 6.47 kB | ✓ |
webpack-07c5..dule.js gzip | 751 B | 751 B | ✓ |
Overall change | 53.2 kB | 53.2 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
polyfills-4b..e242.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-7231d4b..5856.js gzip | 1.28 kB | N/A | N/A |
_error-fca3d..2eb1.js gzip | 3.44 kB | N/A | N/A |
hooks-d4591d..e7c2.js gzip | 887 B | N/A | N/A |
index-17468f..5d83.js gzip | 227 B | 227 B | ✓ |
link-8a9d104..0e42.js gzip | 1.55 kB | N/A | N/A |
routerDirect..924c.js gzip | 284 B | 284 B | ✓ |
withRouter-7..c13d.js gzip | 284 B | 284 B | ✓ |
_app-3b0cf13..85f8.js gzip | N/A | 1.28 kB | N/A |
_error-6f635..c393.js gzip | N/A | 3.44 kB | N/A |
hooks-d4ffc3..9e0f.js gzip | N/A | 887 B | N/A |
link-0abe79e..7616.js gzip | N/A | 1.55 kB | N/A |
Overall change | 7.96 kB | 7.96 kB | ✓ |
Client Pages Modern
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_app-75d3a82..dule.js gzip | 625 B | 625 B | ✓ |
_error-4469a..dule.js gzip | 2.29 kB | N/A | N/A |
hooks-cbf13f..dule.js gzip | 387 B | 387 B | ✓ |
index-b9a643..dule.js gzip | 226 B | 226 B | ✓ |
link-d1cfb87..dule.js gzip | 1.49 kB | 1.49 kB | ✓ |
routerDirect..dule.js gzip | 284 B | 284 B | ✓ |
withRouter-f..dule.js gzip | 282 B | 282 B | ✓ |
_error-f2fcc..dule.js gzip | N/A | 2.29 kB | N/A |
Overall change | 5.59 kB | 5.59 kB | ✓ |
Client Build Manifests Overall decrease ✓
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_buildManifest.js gzip | 322 B | 321 B | -1 B |
_buildManife..dule.js gzip | 330 B | 330 B | ✓ |
Overall change | 652 B | 651 B | -1 B |
Serverless bundles
vercel/next.js canary | merceyz/next.js merceyz/babel-runtime | Change | |
---|---|---|---|
_error.js | 916 kB | 916 kB | ✓ |
404.html | 4.61 kB | 4.61 kB | ✓ |
hooks.html | 3.86 kB | 3.86 kB | ✓ |
index.js | 916 kB | 916 kB | ✓ |
link.js | 965 kB | 965 kB | ✓ |
routerDirect.js | 958 kB | 958 kB | ✓ |
withRouter.js | 958 kB | 958 kB | ✓ |
Overall change | 4.72 MB | 4.72 MB | ✓ |
They'd need to be different for each file so I don't see how that would help |
I see, it seems the reverting may be the best bet then - is there another fix for Yarn that might apply? |
Shouldn't |
Only place I can find a absolute path in the build output is in |
Maybe a solution could also be to mark |
I'm afraid that wont fix it, reverting this commit and making |
@merceyz I guess the logic is that @babel/runtime is effectively being considered as a peer dependency here? Two things then - that's what Next.js has always done I believe? So the issue was only exposed as opposed to created right? Secondly, inlining might be an option but I'm not sure if that in turn might have knock-on effects? I'd prefer if we could just externalize as before to be honest, the goal was to match the previous behaviour before #18768 landed. |
I'll expand on my comment in case our use case is helpful. The issue I am having is that with this change the transpiled code is no longer portable from one environment to another. In order to keep our containers small, we do not include all of the dependencies to build our project in the docker container. So when we run CI, we build the code and copy it into the container. In the container we only install the runtime dependencies. The issue is now that these paths are hardcoded, if the paths do not match in the runtime environment to the build environment it cannot find the babel runtime. I can work around this by just making sure these paths match, so this change is by no means a deal breaker, I just wish it were at least highlighted as a breaking change and perhaps in a 10.1.x release rather than lost in a patch level changelog. If there is a better way we could be handling our build to avoid this pain point I appreciate your feedback. Regards, |
@koshea I only see the paths in the babel loader cache which shouldn't matter and when running
@guybedford That would replace one issue with another, the previous solution only applied the correct logic when using PnP, something else needs to be fixed
I'm fairly certain that is not the intent as it would require the user to add it as a dependency |
@merceyz are you saying this issue did not exist before #18768? I'm still not clear on why that is. |
It did, but only when running under PnP, this PR changed it to always be applied (which is the correct behaviour, otherwise it relies on hoisting) while also resolving it up front instead of having babel do it |
Then the suggestion of externalizing resolve would be the direct fix of that regression, while not fixing the root cause. I'm just saying that might be a good first step, before then later attacking the full inlining which may have further repercussions otherwise. |
I'd also be interested to know what the behaviour is in |
In that case, we can just add back the check for if it's running under PnP or not, then nothing will (effectively) have changed since before #18768. Though I would like to look at a reproduction of the issue first to see if it's fixable
Yarn patches it at install time to add PnP support, when it's inlined we can't see it |
Actually inlining |
@merceyz well, now that I review the codebase, the issue is actually due to the fact that we sometimes utilize the code transpiled by the next babel preset to share code between packages, and this is not necessarily run through webpack. |
You can pass next.js/packages/next/build/babel/preset.ts Line 176 in 30c2dfd
@RossMcMillan92 is this what is happening to you as well? |
That solves my problem, thank you @merceyz ! |
)" This reverts commit d40d7d6.
Yes, I think this has fixed our deployment. Thanks for the tip. For anyone looking for an easy answer, add this to your babelrc file: presets: [
['next/babel', { 'transform-runtime': { absoluteRuntime: false } }],
], Still, feels like we shouldn't have to do this. |
So you're using the preset outside of the webpack build? If that is the case then #19538 is the solution |
I didn't notice at first, but you are correct. We're using Thanks for pointing that out, I would never have realised. #19538 may indeed be the solution then |
Perfect, thanks for confirming! |
…arnPnp (vercel#19542) This reverts vercel#18921 and ensures that the Babel runtime is only inlined as an absolute path when using PnP as before, but then including the correction this resolution as implemented by @merceyz only in the PnP cases, while keeping the diff to a minimum.
…19538) **What's the problem this PR addresses?** In #18921 I enabled `absoluteRuntime` for everyone (it was only enabled for PnP users) but didn't consider that people used the babel preset outside of the webpack build. Fixes #19448 - ~~Since it doesn't contain a repro I can't be certain but based on feedback from @koshea in #18921 (comment) I'll assume @RossMcMillan92 is doing the same thing, because when next is building it doesn't leave absolute paths as external.~~ Confirmed in #18921 (comment) **How did you fix it?** Only enable `absoluteRuntime` when the preset is running under `babel-loader`
What's the problem this PR addresses?
#18768 started to ncc
@babel/plugin-transform-runtime
which broke its Yarn PnP support since the version ofresolve
it uses can't be patched by Yarn.Fixes https://github.com/yarnpkg/berry/runs/1359235077?check_suite_focus=true#step:5:79
cc @guybedford
How did you fix it?
Resolve the absolute path to
@babel/runtime
so it doesn't have to go throughresolve
Fixes #19026